Update CLI banner with FastMCP 3.0 notice#2766
Conversation
|
Warning Rate limit exceeded@jlowin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/fastmcp/utilities/cli.py (1)
216-218: Consider removing commented code.The info table construction looks correct, but line 217 contains commented-out code. Consider either removing it entirely or uncommenting it if the docs row should be displayed.
🔎 Proposed cleanup
info_table.add_row("🖥", "Server:", Text(server.name, style="dim")) -# info_table.add_row("📚", "Docs:", "https://gofastmcp.com") info_table.add_row("🚀", "Deploy free:", "https://fastmcp.cloud")
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/fastmcp/server/server.pysrc/fastmcp/utilities/cli.py
🧰 Additional context used
📓 Path-based instructions (1)
src/fastmcp/**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
src/fastmcp/**/*.py: Python ≥ 3.10 with full type annotations required
Prioritize readable, understandable code - clarity over cleverness. Avoid obfuscated or confusing patterns even if shorter
Follow existing patterns and maintain consistency in code implementation
Be intentional about re-exports - don't blindly re-export everything to parent namespaces. Core types defining a module's purpose should be exported. Specialized features can live in submodules. Only re-export to fastmcp.* for most fundamental types
Never use bare except - be specific with exception types
Files:
src/fastmcp/utilities/cli.pysrc/fastmcp/server/server.py
🧠 Learnings (1)
📚 Learning: 2025-12-25T15:53:07.646Z
Learnt from: CR
Repo: jlowin/fastmcp PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-25T15:53:07.646Z
Learning: Applies to tests/**/*.py : Pass FastMCP servers directly to clients for testing without network complexity; only use HTTP transport when explicitly testing network features
Applied to files:
src/fastmcp/server/server.py
🔇 Additional comments (6)
src/fastmcp/server/server.py (2)
2063-2063: LGTM!The function call correctly uses the simplified signature, passing only the server parameter.
2128-2128: LGTM!The function call correctly uses the simplified signature, consistent with the stdio transport implementation.
src/fastmcp/utilities/cli.py (4)
6-6: LGTM!The import statement correctly removes
Literal, which is no longer needed after simplifying the function signature.
200-201: LGTM!The function signature is correctly simplified with proper type annotations, aligning with the PR's goal to streamline the banner display.
234-243: LGTM!The v3 notice panel is well-implemented with clear messaging and actionable guidance for users. The styling is consistent with the main panel, and the message aligns perfectly with the PR objectives.
254-255: LGTM!The final rendering correctly displays both the main panel and v3 notice panel with proper centering and spacing.
Test Failure AnalysisSummary: The Windows Python 3.10 test is failing due to a timeout during OAuth provider initialization, not related to the banner changes in this PR. Root Cause: The test Evidence:
Suggested Solution: This is a known flaky test issue on Windows with
Detailed AnalysisStack TraceThe timeout occurs during initialization: Why This Isn't Related to PR ChangesThis PR only modifies:
The failing test doesn't call Related Files
|
Updating CLI with 3.0 message.